[Webkit-unassigned] [Bug 51099] [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing Korean

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51099


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76730|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Andreas Kling <kling at webkit.org>  2011-04-26 15:38:12 PST ---
(From update of attachment 76730)
View in context: https://bugs.webkit.org/attachment.cgi?id=76730&action=review

How can we test this?

> WebKit/qt/Api/qwebpage.cpp:1098
> +        // that the caret is vanished. after finishing composition, caret should
> +        // be visible.

Grammar.
When compositing Korean, 'ev' is of type Cursor with length=0. This causes the caret to vanish. After the composition finishes, the caret should be visible.

> WebKit/qt/Api/qwebpage.cpp:1102
> +        // If preeditSting exists, Caret should be visible.

preeditSting -> preeditString
Caret -> the caret

> WebKit/qt/Api/qwebpage.cpp:1105
> +        // next to composition, not in front of composition.

next to composition -> next to the composition
in front of composition -> in front of the composition

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.