[Webkit-unassigned] [Bug 59411] [EFL] Change cursor to LAZY_NATIVE_CURSOR

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 15:11:18 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59411


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91051|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2011-04-26 15:11:18 PST ---
(From update of attachment 91051)
View in context: https://bugs.webkit.org/attachment.cgi?id=91051&action=review

Looks fine except for the , strangeness.  I think we only do the leading comma for initializer lists.

> Source/WebCore/platform/efl/CursorEfl.cpp:62
> +        "cursor/pointer"
> +        , "cursor/cross"

I think we would normally write this "foo", and put a comma after every line.  But I'm not sure.

> Source/WebCore/platform/efl/CursorEfl.cpp:104
> +        , ""};

What's this for?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list