[Webkit-unassigned] [Bug 56375] [Qt] PageGroup::closeLocalStorage() should be called when the app quits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56375


Joe Wild <joseph.wild at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91169|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Joe Wild <joseph.wild at nokia.com>  2011-04-26 15:05:58 PST ---
Created an attachment (id=91169)
 --> (https://bugs.webkit.org/attachment.cgi?id=91169&action=review)
Close Icon and Local Storage Databases on Quit

Added QWebView::shutDownWebKit to close the Icon and Local Storage Databases.
This Signal was connected to the application's aboutToQuit Slot.

    connect(QCoreApplication::instance(), SIGNAL(aboutToQuit()),
            this, SLOT(shutDownWebKit()));

This was suggested in the error and as is done on other platforms (Windows).
Then I connected the Signal lastWindowClosed to Slot quit(), so
aboutToQuit would be signaled.

    connect(QApplication::instance(), SIGNAL(lastWindowClosed()),
        QApplication::instance(), SLOT(quit()));

It turns out that calling WebCore::PageGroup::closeLocalStorage() does
not close the local storage.  Local storage is closed the
WebCore::PageGroup is destroyed.  I kept the call to
closeLocalStorage() because it was consistent with other platforms and
does not hurt anything.  Calling WebCore::iconDatabase()->close() in
shutDownWebKit does close that db.

This was clean up which did not change any functionality, so did not
add any new tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.