[Webkit-unassigned] [Bug 59414] Implement CSS border width and related properties in CSSStyleApplyProperty.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59414





--- Comment #8 from Nikolas Zimmermann <zimmermann at kde.org>  2011-04-26 10:51:00 PST ---
(In reply to comment #7)
> (From update of attachment 91049 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91049&action=review
> 
> Do we have some performance testing results for this change?
> 
> > Source/WebCore/css/CSSStyleApplyProperty.cpp:87
> > +    ApplyPropertyDefaultBase(T (RenderStyle::*getter)() const, void (RenderStyle::*setter)(T), T (*initial)())
> 
> These pointer-to-member-function and function types are a little hard to read. Maybe we could use typedefs instead of putting the type here directly to make the code easier to read.
> 
> > Source/WebCore/css/CSSStyleApplyProperty.cpp:104
> > +    virtual void applyValue(CSSStyleSelector*, CSSValue*) const {}
> 
> Can this be a pure virtual function instead? Is the empty version of the function ever helpful?

Just for the record, I asked for these things (typedef) after CSSStyleApplyProperty has landed nearly 2 months ago :(
Luke, could you make those changes? I'm happy to review the patch...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.