[Webkit-unassigned] [Bug 49468] [Qt] Assertion failure in DocumentLoader::commitData when loading a media document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49468


Joe Wild <joseph.wild at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89853|0                           |1
        is obsolete|                            |
  Attachment #91036|                            |review?, commit-queue?
               Flag|                            |




--- Comment #2 from Joe Wild <joseph.wild at nokia.com>  2011-04-25 17:52:06 PST ---
Created an attachment (id=91036)
 --> (https://bugs.webkit.org/attachment.cgi?id=91036&action=review)
Cancel load of top level media content before reset/assert

If this fix it correct it was very simple.  As several others have
pointed out, the continued load of content that will be handled by the
MediaDocument causes a reset/assert.  My fix just cancels that load.

I was not unable to find much information on how the
MediaDocument/Plugins should behave, so I focused on fixing the reset.
>From what I can tell the HTML with Video Element that is generated is
never correctly processed due to unimplemented features (at least on
QtWebkit Linux).  Same happens with hand created HTML with a video
element.

Also, this error has been around for awhile.  These 2 errors were investigated
in 2009.  One was marked as a dup of the other, and the other was closed
as Resolved Invalid on 2009-09-08 with no comment why.

  https://bugs.webkit.org/show_bug.cgi?id=25427
  https://bugs.webkit.org/show_bug.cgi?id=25429

I added a test that just loads a .wav file as the top level content of an
<iframe> under

  LayoutTests/plugins/audio-top-level-wav-load.html.

For this to really be tested with DumpRenderTree on QtWebKit,
QTWEBKIT_PLUGIN_PATH has to be defined so the Plugins are loaded to
get the point of the reset/assert.  Not sure if this is the best place
to put this test.  Open to suggestions.  I picked LayoutTest/plugins over
LayoutTests/media because the latter are not run on QtWebkit Linux.

I did test on Mac QtWebkit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.