[Webkit-unassigned] [Bug 59234] CrossThreadCopier should not have a default specialization for raw pointers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59234


Dmitry Lomov <dslomov at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90764|0                           |1
        is obsolete|                            |
  Attachment #90930|                            |review?, commit-queue?
               Flag|                            |




--- Comment #5 from Dmitry Lomov <dslomov at google.com>  2011-04-25 10:44:46 PST ---
Created an attachment (id=90930)
 --> (https://bugs.webkit.org/attachment.cgi?id=90930&action=review)
Proposed patch: second iteration

Code review feedback addressed.

There is one real (and quite horrible) issue that this patch uncovered - direct your attention to changes in  IDBObjectStoreBackendImpl.cpp.
In two places, the code created a 
   RefPtr<Transaction> transactionPtr = transaction;
where transaction is Transaction*, but then passed a transaction, and not a transactionPtr, to a scheduled task. Why this does not die a horrible death I have no idea.
I would venture a suggestion that, besides a lax implementation of CrossThreadCopier, a horrendous line length that pushed arguments to scheduleTask way beyond an editor view port, was a contributing factor to this bug.

On a subject of AllowExtendedLifetime: my suggestion would be - let us keep AllowExtendedLifetime as an eyesore - it is something that should not be there. ScriptExecutionContext should have a special method that only schedules tasks on current thread.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.