[Webkit-unassigned] [Bug 58852] [GTK] Add proxy support to GtkLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58852





--- Comment #8 from Ryuan Choi <ryuan.choi at samsung.com>  2011-04-24 21:44:07 PST ---
(In reply to comment #6)
> (From update of attachment 90675 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90675&action=review
> 
> Okay. This seems alright in the end.
> 
> > Tools/ChangeLog:9
> > +        * GtkLauncher/main.c:
> > +        (main):
> 
> Please fill this out before landing.

added some comment.

> 
> > Tools/GtkLauncher/main.c:245
> > +    const char *httpProxy = getenv("http_proxy");
> 
> I think it would be better to call g_getenv here instead.

Done.

Thank you for review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.