[Webkit-unassigned] [Bug 59182] [Chromium] Vertical positions are off for some Arabic glyphs on Linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 24 18:12:46 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59182





--- Comment #4 from Kenichi Ishibashi <bashi at chromium.org>  2011-04-24 18:12:46 PST ---
Hi Evan,

Thank you for taking a look of this patch.

(In reply to comment #2)
> Did you create this font yourself?  (I am worried about licensing)

Yes, I've created it with FontForge from scratch so I think there is no licensing issue.  I'll add an explanation of it.

> > Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h:64
> > +    ComplexTextController(const TextRun&, unsigned, unsigned, const Font*);
> 
> Is it necessary to take the startingY as an argument since the users always want 0?  (Now that I look, maybe both of these unsigned arguments aren't needed; they might be left over from previous refactorings.)

I might have wrong idea, but I couldn't find other way to pass the starting position to ComplexTextController.  As far as I checked, the starting point is not always zero at FontLinux::drawComplexText().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list