[Webkit-unassigned] [Bug 23346] Restore form control values to a wrong form

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23346


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P1




--- Comment #45 from Kent Tamura <tkent at chromium.org>  2011-04-24 13:19:16 PST ---
I have thought how to resolve this issue for one year.  My current thought is below:


What is this feature?
  The purpose of the feature is to restore user-input values without on-memory back-forward cache.
   -> So, we should not restore values for non user-editable controls such as elements with no renderer, visibility:none style, read-only/disabled elements.
   -> We should restore for controls with autocomplete=off because users can edit them.
   -> WebKit should fire 'change' events when values are restored because restoring is a kind of user-input.

What's wrong with the current implementation?
  * Values are restored to unexpected controls.
    This often happens for dynamically generated pages.
    -> We should check page identity more strictly.  Currently we have queues for type-name pairs.  We should have stricter data structure such as a list of type-name.

  * Values are restored to dynamically-generated controls.
    If the restore value queue is not empty and a dynamically-generated control accidentally match to a type-name pair in the queue, the control has the restored value.
    -> We should restore values only once, and purge unused saved values just after that.
        IMO, we should restore values just after document's 'load' event because the 'load' event is often used to build a page.  If we change so, we won't restore values for controls added after the 'load' event. 


Comments?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.