[Webkit-unassigned] [Bug 59138] REGRESSION(81625): Tables are not rendered correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59138





--- Comment #18 from Rik Cabanier <cabanier at adobe.com>  2011-04-23 12:30:02 PST ---
(In reply to comment #17)
> (From update of attachment 90842 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90842&action=review
> 
> > Source/WebCore/rendering/AutoTableLayout.cpp:270
> > +    } else if (!remainingPercent && maxNonPercent)
> > +        // if there was no remaining percent, maxWidth is invalid.
> >          maxWidth = intMaxForLength;        
> 
> Braces are preferred when a comment is included above a single-line clause.

Will do

> 
> > LayoutTests/fast/table/auto-100-percent-width.html:9
> > +function test()
> > +{
> > +    if (window.layoutTestController)
> > +        layoutTestController.dumpAsText();
> > +}
> > +</script>
> 
> The dumpAsText() makes this a text test, so the output doesn't show the sizes of the render objects. You can see the output above; how does that reveal whether the bug is fixed?
> 
> Part of your workflow should be to ensure that the LayoutTest reproduces failure without the fix in the code.
> 
> I think in this case you can just remove the entire <script> block. The <div> is also unnecessary.

I was wondering about that. I assumed that it was putting it out as binary or something.
I will fix the text.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.