[Webkit-unassigned] [Bug 12499] External <use> xlink:href references do not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=12499


Cosmin Truta <ctruta at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86746|0                           |1
        is obsolete|                            |




--- Comment #60 from Cosmin Truta <ctruta at gmail.com>  2011-04-23 02:17:50 PST ---
Created an attachment (id=90851)
 --> (https://bugs.webkit.org/attachment.cgi?id=90851&action=review)
Draft patch

Here is a patch in which I'm addressing Rob's comments, and making other necessary changes in order to make it build with the WebKit du jour. Notably, I accounted for CachedResource::DocumentResource inside CachedResourceLoader::canRequest, in the light of the newly-added ContentSecurityPolicy class.

There are no significant fixes, though, as I haven't had sufficient time for that. (I'm only working on this in my spare time, which, nowadays, is very little.)

I noticed that, inside SVGUseElement::parseMappedAttribute, document()->baseURI() is invalid when the <use> element is inside a cached document. This is the reason behind the failure that I described in the example from comment #54. The cached document's m_baseURL needs to be initialized, and the place to do that (I think) is right at the point where it's created, i.e. inside CachedDocument::data(). I didn't get to make it work yet, though. A simple call to m_document->setDocumentURI(m_url) doesn't seem to be sufficient, and I'm looking into that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.