[Webkit-unassigned] [Bug 59138] REGRESSION(81625): Tables are not rendered correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59138





--- Comment #12 from Nico Weber <thakis at chromium.org>  2011-04-22 21:14:01 PST ---
(From update of attachment 90839)
View in context: https://bugs.webkit.org/attachment.cgi?id=90839&action=review

> Source/WebCore/rendering/AutoTableLayout.cpp:270
>      if (!remainingPercent && maxNonPercent)

You're saying

  else
  // comment
  if (foo)

I think 

  // comment
  else if (foo)

is nicer.

(And I guess

bool maxWidthValid = !remainingPercent && maxNonPercent;
  ...
  else if (maxWidthValid)

is even more WebKit-style.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.