[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #19 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2011-04-22 20:27:52 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > This issue seems to be solved by a patch for bug58806. :|
> 
> Does it pass all of the test cases I had on mine? 
I tested that my patch passed your test cases included in your patch.
Yes. it passed all. Of course, it passed all layout tests except three things I mentioned above. :)

> My only concern with this patch is that it doesn't
> check if there is a trailing space when it tries to position the float
> ignoring additional space. 
In my opinion, no problem without additional checking if there is a trailing space. Because it already verified with following line,
> if (currentCharacterIsSpace && additionalTmpW)
>     width.setAdditionalWidth(additionalTmpW); 
m_additionalWidth is initialized with 0. And we set only non-zero value when current Character is a "space". This means that if m_additionalWidth isn't zero, there is a trailing space. Otherwise m_additialalWidth doesn't affect anything.

> I wonder if this could overlap a character or if it works out.
I've tested some kinds of situation like, multiple floats, no space between floats, multiple spaces between float, multiple text strings between float, multiple spaces in float and so on...
But I've found nothing special.

Thank you for your kind comment, and concern. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.