[Webkit-unassigned] [Bug 58953] [V8] Use implicit references for V8 listeners on DOM nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58953


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90823|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2011-04-22 18:23:26 PST ---
(From update of attachment 90823)
View in context: https://bugs.webkit.org/attachment.cgi?id=90823&action=review

> Source/WebCore/dom/EventTarget.cpp:394
> +EventListenerIterator::EventListenerIterator() : m_index(0)

Sorry, this initializer needs to be on its own line too.

> Source/WebCore/dom/EventTarget.h:197
> +        EventListener* nextListener();

I would add a comment admonishing folks not to modify the listener list durning iteration because that will cause big problems for this iterator.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.