[Webkit-unassigned] [Bug 58953] [V8] Use implicit references for V8 listeners on DOM nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58953





--- Comment #6 from Adam Barth <abarth at webkit.org>  2011-04-22 17:07:00 PST ---
(From update of attachment 90797)
View in context: https://bugs.webkit.org/attachment.cgi?id=90797&action=review

> Source/WebCore/bindings/v8/V8AbstractEventListener.h:94
> +        v8::Persistent<v8::Object> getExistingListenerObjectPersistentHandle()

Please remove "get" prefix.

> Source/WebCore/dom/EventTarget.cpp:394
> +EventListenerIterator::EventListenerIterator() : m_index(0) {}

The { and } should each be on their own line.

> Source/WebCore/dom/EventTarget.cpp:396
> +EventListenerIterator::EventListenerIterator(EventTarget* target) : m_index(0)

": m_index(0)" should be on its own line and indented four spaces.

> Source/WebCore/dom/EventTarget.cpp:410
> +        EventListenerVector& listeners = *m_mapIterator->second;
> +        if (m_index < listeners.size())
> +            return listeners[m_index++].listener.get();

We don't need to reset m_index to zero when we ++m_mapIterator ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.