[Webkit-unassigned] [Bug 59183] Overlay scroller hard to see on pages with dark background

Fri Apr 22 14:15:25 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59183

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90758|commit-queue?               |commit-queue+
               Flag|                            |

--- Comment #6 from Beth Dakin <bdakin at apple.com>  2011-04-22 14:15:25 PST ---
(From update of attachment 90758)
View in context: https://bugs.webkit.org/attachment.cgi?id=90758&action=review

> Source/WebCore/platform/ScrollableArea.cpp:201
> +ScrollbarOverlayStyle ScrollableArea::recommendedScrollbarOverlayStyle()

Since this is a one-line function, it would be nice to have it implemented in the header.

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:39
> +

Unnecessary whitespace. You should remove this.

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:-449
> -

Arguably this whitespace was valuable. But I'll leave that up to you. :-)

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:230
> +    

Unnecessary tab-whitespace. Should remove.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.