[Webkit-unassigned] [Bug 56682] Opening link with unspecific hash in a new tab (except context menu) twice in a row results in hash for current window changing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56682


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90367|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2011-04-22 09:17:07 PST ---
(From update of attachment 90367)
View in context: https://bugs.webkit.org/attachment.cgi?id=90367&action=review

> Source/WebCore/loader/FrameLoader.cpp:1381
> +    if (event && event->isMouseEvent()) {
> +        RefPtr<MouseEvent> mouseEvent = static_pointer_cast<MouseEvent>(event);
> +#if PLATFORM(MAC)
> +        if (mouseEvent->metaKey()) {
> +#else
> +        if (mouseEvent->ctrlKey() || mouseEvent->button() == MiddleButton) {
> +#endif
> +            policyChecker()->checkNewWindowPolicy(action, FrameLoader::callContinueLoadAfterNewWindowPolicy,
> +                request, formState.release(), frameName, this);
> +            return;
> +        }

This is the wrong place to do this work.  The FrameLoader shouldn't understand anything about the meta or ctrl keys.  Even worse, it shouldn't be encoding platform-specific behavior!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.