[Webkit-unassigned] [Bug 58852] [GTK] Add proxy support to GtkLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58852


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90675|review?                     |review+
               Flag|                            |




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-04-22 09:06:59 PST ---
(From update of attachment 90675)
View in context: https://bugs.webkit.org/attachment.cgi?id=90675&action=review

Okay. This seems alright in the end.

> Tools/ChangeLog:9
> +        * GtkLauncher/main.c:
> +        (main):

Please fill this out before landing.

> Tools/GtkLauncher/main.c:245
> +    const char *httpProxy = getenv("http_proxy");

I think it would be better to call g_getenv here instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.