[Webkit-unassigned] [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59193


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90696|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2011-04-22 06:40:25 PST ---
(From update of attachment 90696)
View in context: https://bugs.webkit.org/attachment.cgi?id=90696&action=review

> Source/WebCore/inspector/front-end/NetworkItemView.js:114
> +WebInspector.NetworkItemView.sourceViewForResource = function(resource)

I don't see where this caching is used. Also, should be private.

> Source/WebCore/inspector/front-end/NetworkItemView.js:123
> +WebInspector.NetworkItemView.contentViewForResource = function(resource)

Should be private.

> Source/WebCore/inspector/front-end/NetworkItemView.js:130
> +        return WebInspector.NetworkItemView.sourceViewForResource(resource);

(do we really cache anything?)

> Source/WebCore/inspector/front-end/ResourcesPanel.js:86
> +    case WebInspector.resourceCategories.documents:

I've seen it earlier. We should not dupe logic like this.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:102
> +    if (!resource._resourcesPanelSourceView)

Can we stop caching views in the resource?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:114
> +    if (!revision._view) {

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.