[Webkit-unassigned] [Bug 59128] HTMLFormControlElement::labels should allow custom attributes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59128





--- Comment #8 from Yael <yael.aharon at nokia.com>  2011-04-22 06:03:43 PST ---
(In reply to comment #5)
> (From update of attachment 90617 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90617&action=review
> 
Thank you for your comments.
> I don't deeply understand what's going one like Sam does, but I've got a few comments.
> 
> > LayoutTests/fast/forms/script-tests/labels-custom-property.js:1
> > +description('Test that we can set and get custom properties on the labels attribute. ');
> 
> Could you please merge these .js and .html files? Keeping them separate causes nothing but difficulties, as you need a second step to get from test to its content.
> 
Will do :)

> > LayoutTests/fast/forms/script-tests/labels-custom-property.js:11
> > +labels.customProperty = 1;
> > +shouldBe('labels.customProperty', '1');
> 
> Can you add a gc() call between these? I can't easily find any code marking the JS wrapper.
Will do :)
I'll submit a new patch once the pointer issue is resolved.
Going through the logs, I see that the way we cache the DynamicNodeList wrappers was changed this week.
Please look at r84309 and r83990.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.