[Webkit-unassigned] [Bug 57784] [Qt][WK2] Qt port needs load-from-history implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57784


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|WebKit2                     |WebKit Qt
         AssignedTo|webkit-unassigned at lists.web |james.cooley at nokia.com
                   |kit.org                     |
                 CC|                            |kling at webkit.org
     Ever Confirmed|0                           |1




--- Comment #4 from Andreas Kling <kling at webkit.org>  2011-04-21 18:07:16 PST ---
(In reply to comment #2)
> (From update of attachment 88120 [details])
> Missing tests and doc.
> I know most methods do in WK2, but that is no excuse for new addition :)

I don't think it's necessary to add doc for the Qt/WK2 APIs at this stage.
We will need a ChangeLog entry though. :)

On another note, this API is rather dirty.

- The name implies that a load will happen, whereas it may as well be a cached page restoration (depending on availability.) The old QWebHistory::goToItem() made more sense in this regard.

- What if the QWKHistoryItem passed to QWKPage::loadFromHistory() comes from another QWKPage's history()?

Since the QWKHistory points to a WebBackForwardList, which internally has a WebPageProxy*, I think it would make more sense that the QWKHistory be aware of the QWKPage that owns it. This way we could put a WK1-style goToItem() into QWKHistory instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.