[Webkit-unassigned] [Bug 59028] Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59028


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90600|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Tony Chang <tony at chromium.org>  2011-04-21 17:02:00 PST ---
(From update of attachment 90600)
View in context: https://bugs.webkit.org/attachment.cgi?id=90600&action=review

The change looks fine, but I think we need to update the other build systems.

> Source/WebCore/WebCore.gypi:2428
> +            'dom/DataTransferItems.cpp',

Should we add this file to the other build systems (xcode, vcproj, etc)?

> Source/WebCore/dom/DataTransferItems.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

I suspect this is the wrong copyright.

> Source/WebCore/dom/DataTransferItems.cpp:47
> +unsigned long DataTransferItems::length()

It would be nice in a follow up patch to change these to size_t since that's what wtf::Vector uses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.