[Webkit-unassigned] [Bug 59136] Null deref when no use element exists for SVG element instance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59136





--- Comment #3 from Justin Schuh <jschuh at chromium.org>  2011-04-21 15:50:13 PST ---
(From update of attachment 90615)
View in context: https://bugs.webkit.org/attachment.cgi?id=90615&action=review

The approach looks good. I just have some style nits and suggested cleanup on the layout test.

> Source/WebCore/svg/SVGAnimationElement.cpp:346
> +            (*it)->correspondingUseElement()->setNeedsStyleRecalc();

You should assign the corresponding use element to a local variable in the "if" condition and use that when calling setNeedsStyleRecalc.

> LayoutTests/svg/misc/null-corresponding-element-crash.svg:12
> +    <circle transform="translate(1)" id="circleID">

You should make the circle visible here, and generally we use a green fill to denote success. How about this:
<circle transform="translate(1)" id="circleID" fill="green" cy="25" cx="25" r="20" >

> LayoutTests/svg/misc/null-corresponding-element-crash.svg:14
> +        <animateTransform attributeName="transform" fill="freeze" />

The fill attributes are unnecessary on animate and animateTransform.

> LayoutTests/svg/misc/null-corresponding-element-crash.svg:17
> +	PASS - Null corresponding element dereference does not crash.

This text is going to render off-screen when running the test manually. You should move it into view. try this:

<text y="70">

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.