[Webkit-unassigned] [Bug 59128] HTMLFormControlElement::labels should allow custom attributes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59128





--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2011-04-21 15:47:21 PST ---
(From update of attachment 90617)
View in context: https://bugs.webkit.org/attachment.cgi?id=90617&action=review

I don't deeply understand what's going one like Sam does, but I've got a few comments.

> LayoutTests/fast/forms/script-tests/labels-custom-property.js:1
> +description('Test that we can set and get custom properties on the labels attribute. ');

Could you please merge these .js and .html files? Keeping them separate causes nothing but difficulties, as you need a second step to get from test to its content.

> LayoutTests/fast/forms/script-tests/labels-custom-property.js:11
> +labels.customProperty = 1;
> +shouldBe('labels.customProperty', '1');

Can you add a gc() call between these? I can't easily find any code marking the JS wrapper.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.