[Webkit-unassigned] [Bug 50564] End/Home keys do not work in a contentEditable element

Thu Apr 21 14:45:41 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=50564

--- Comment #9 from Enrica Casucci <enrica at apple.com>  2011-04-21 14:45:41 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > But shouldn't we do this inside honorEditableBoundaryAtOrBefore/honorEditableBoundaryAtOrAfter?
> 
> honorEditableBoundary___ is used in various places throughout the code and the contract now is that it'll return an empty VisiblePosition if the position it's supposed to change to honor the boundary isn't actually inside the highest root: "Return empty position if pos is not somewhere inside the editable region containing this position"
> 
> Changing this breaks other call sites. The other option is to add a paramater to those functions to support this different expectation.

I think this makes the code more confusing. I'd rather have it in your initial version, with the use of the contains method the Ryosuke suggested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.