[Webkit-unassigned] [Bug 51063] REGRESSION (WebKit2): No context menu appears when right-clicking on windowless Flash plugin

Thu Apr 21 13:44:55 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=51063

Brian Weinstein <bweinstein at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90582|review?                     |review+
               Flag|                            |

--- Comment #21 from Brian Weinstein <bweinstein at apple.com>  2011-04-21 13:44:55 PST ---
(From update of attachment 90582)
View in context: https://bugs.webkit.org/attachment.cgi?id=90582&action=review

>>> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:354
>>> +        hWnd = currentPlugin->m_contextMenuOwnerWindow;
>> 
>> It seems a bit strange to overwrite the hWnd argument here instead of using a local, but that's probably just because I'm not used to seeing it.
> 
> I don't personally find it strange. And overwriting the hWnd argument is what this function is all about! But I'm happy to change it if you think it would be more readable using a local.

It's fine, I just am not as used to seeing that style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.