[Webkit-unassigned] [Bug 51063] REGRESSION (WebKit2): No context menu appears when right-clicking on windowless Flash plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51063





--- Comment #18 from Adam Roben (:aroben) <aroben at apple.com>  2011-04-21 13:36:11 PST ---
(From update of attachment 90582)
View in context: https://bugs.webkit.org/attachment.cgi?id=90582&action=review

>> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:32
>> +#include <WebCore/WebCoreInstanceHandle.h>
> 
> This seems to be sorted wrong. Not sure why style bot didn't catch it.

Hm, true! I'll fix it.

>> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:354
>> +        hWnd = currentPlugin->m_contextMenuOwnerWindow;
> 
> It seems a bit strange to overwrite the hWnd argument here instead of using a local, but that's probably just because I'm not used to seeing it.

I don't personally find it strange. And overwriting the hWnd argument is what this function is all about! But I'm happy to change it if you think it would be more readable using a local.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.