[Webkit-unassigned] [Bug 51063] REGRESSION (WebKit2): No context menu appears when right-clicking on windowless Flash plugin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 13:21:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=51063





--- Comment #13 from Jeff Miller <jeffm at apple.com>  2011-04-21 13:21:04 PST ---
(From update of attachment 90581)
View in context: https://bugs.webkit.org/attachment.cgi?id=90581&action=review

> Source/WebCore/platform/win/DelayLoadedModulesEnumerator.cpp:80
> +        // relative.

Seems like this comment could be all on one line.

> Source/WebCore/platform/win/ImportedModulesEnumeratorBase.h:42
> +    ~ImportedModulesEnumeratorBase() { }

~ImportedModulesEnumeratorBase() should be virtual.

> Source/WebCore/platform/win/PEImage.cpp:54
> +{

Maybe you should ASSERT(isValid()) here, and/or return 0 if !isValid().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list