[Webkit-unassigned] [Bug 59030] Make WebKit expose extra touch information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59030


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90568|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2011-04-21 12:33:32 PST ---
(From update of attachment 90568)
View in context: https://bugs.webkit.org/attachment.cgi?id=90568&action=review

I was also going to complain about text alignment (we normally use one space), but those are all pre-exisintg issues in this code.

I don't object to landing this, given the kind of support there already is for touch events.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

The patch can't be landed with this line. You should add tests.

> Source/WebKit/chromium/public/WebTouchPoint.h:52
> +        , rotationAngle(0.0) { }

Just "0", and the braces should go on separate lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.