[Webkit-unassigned] [Bug 59082] [GTK] DRT: implement eventSender.scalePageBy

Thu Apr 21 08:59:57 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59082

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90504|review?                     |review+
               Flag|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-04-21 08:59:57 PST ---
(From update of attachment 90504)
View in context: https://bugs.webkit.org/attachment.cgi?id=90504&action=review

Awesome! Thanks for implementing this.

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:787
> +void DumpRenderTreeSupportGtk::scale(WebKitWebView* webView, float scaleFactor, float x, float y)

Please name this method scalePageBy to match the name of the callback in DRT. This will make it more obvious why this is needed above the scaling options we already have in our API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.