[Webkit-unassigned] [Bug 59100] Web Inspector: Tiny improvement to UI for adding an XHR breakpoint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59100


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90529|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2011-04-21 08:03:04 PST ---
(From update of attachment 90529)
View in context: https://bugs.webkit.org/attachment.cgi?id=90529&action=review

Overall looks good. r- for not localizing the string + expensive selector. Also, please attach images with screenshots when suggesting visual changes.

> Source/WebCore/ChangeLog:1
> +2011-04-21  Mike West  <mkwst at google.com>

Please attach screenshot for visual changes.

> Source/WebCore/ChangeLog:11
> +        Need a short description and bug URL (OOPS!)

There should be no OOPS lines.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:268
> +        inputElementContainer.textContent = WebInspector.UIString("Break when URL contains:");

New localized strings should be added into WebCore/English.lproj/localizedStrings.js

> Source/WebCore/inspector/front-end/inspector.css:1744
> +.pane > .body .breakpoint-condition span {

This selector is too expensive. Could you please assign a class name (or id) to the span?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.