[Webkit-unassigned] [Bug 52513] SVG feDropShadow implementation of SVG Filters 1.2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52513


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90515|review?                     |review-
               Flag|                            |




--- Comment #16 from Nikolas Zimmermann <zimmermann at kde.org>  2011-04-21 06:04:43 PST ---
(From update of attachment 90515)
View in context: https://bugs.webkit.org/attachment.cgi?id=90515&action=review

Patch looks great, one problem though leading to r-:

> Source/WebCore/svg/SVGFEDropShadowElement.cpp:130
> +    RefPtr<RenderStyle> filterStyle = styleForRenderer();

styleForRenderer()? SVGFEDropShadowElement has it's own renderer through SVGFilterPrimitiveStandardAttributes. You have to ask your renderer for the style, don't do manual style resolution!
(I guess you copied that from another wrong SVGFE* Element?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.