[Webkit-unassigned] [Bug 59017] [GTK] Implement History API FrameLoaderClient methods

Wed Apr 20 21:07:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59017

Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gns at gnome.org,
                   |                            |xan.lopez at gmail.com

--- Comment #6 from Xan Lopez <xan.lopez at gmail.com>  2011-04-20 21:07:09 PST ---
Dumping here some comments Martin and I had about this on jabber:

- If we commit the patch as-is we break at least one invariant our code had before: we'll emit a provisional load signal without having a provisional data source/request. In theory this cannot happen.

- If we skip the provisional stage this to avoid the former, we break another invariant: we go through committed and finished before having started at provisional. I believe this, also, cannot happen in theory.

So I'm having second thoughts about this. If I had to choose I'd probably decide to go for option a). CCing Gustavo in case he wants to comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.