[Webkit-unassigned] [Bug 58960] [Chromium]Mac UI polish to add left/right padding space for autofill popup window.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58960





--- Comment #9 from Naoki Takano <takano.naoki at gmail.com>  2011-04-20 14:48:24 PST ---
Thank you for review, guys!!

(In reply to comment #6)
> (From update of attachment 90299 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review
> > Source/WebCore/ChangeLog:12
> > +        The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
> 
> Can you provide more context? like a bug link?
I already included the link in ChangeLog as following,

+        [Chromium]Mac UI polish to add left/right padding space for autofill popup window.
+        https://bugs.webkit.org/show_bug.cgi?id=58960
+        http://code.google.com/p/chromium/issues/detail?id=51077

Do I have to add more extra info?

> 
> > Source/WebCore/rendering/RenderThemeChromiumMac.h:59
> > +    int popupInternalPaddingLeft(RenderStyle*) const;
> > +    int popupInternalPaddingRight(RenderStyle*) const;
> 
> Aren't these virtual calls? (we always mark virtual calls as virtual even though it's not strictly required by the spec).
Yes, you are right. I'll add them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.