[Webkit-unassigned] [Bug 59018] [chromium] Move Chromium media controls into own root element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59018





--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2011-04-20 13:52:59 PST ---
(From update of attachment 90403)
View in context: https://bugs.webkit.org/attachment.cgi?id=90403&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

THe "OOPS" will prevent your patch from being committed. If no new tests are necessary, please explain why.

> Source/WebCore/ChangeLog:40
> +        * css/mediaControlsChromium.css:
> +        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
> +        * html/shadow/MediaControlRootElementChromium.cpp: Added.
> +        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
> +        (WebCore::MediaControls::create):
> +        (WebCore::MediaControlRootElementChromium::create):
> +        (WebCore::MediaControlRootElementChromium::show):
> +        (WebCore::MediaControlRootElementChromium::hide):
> +        (WebCore::webkitTransitionString):
> +        (WebCore::opacityString):
> +        (WebCore::MediaControlRootElementChromium::makeOpaque):
> +        (WebCore::MediaControlRootElementChromium::makeTransparent):
> +        (WebCore::MediaControlRootElementChromium::reset):
> +        (WebCore::MediaControlRootElementChromium::playbackStarted):
> +        (WebCore::MediaControlRootElementChromium::playbackProgressed):
> +        (WebCore::MediaControlRootElementChromium::playbackStopped):
> +        (WebCore::MediaControlRootElementChromium::updateTimeDisplay):
> +        (WebCore::MediaControlRootElementChromium::reportedError):
> +        (WebCore::MediaControlRootElementChromium::changedNetworkState):
> +        (WebCore::MediaControlRootElementChromium::loadedMetadata):
> +        (WebCore::MediaControlRootElementChromium::changedClosedCaptionsVisibility):
> +        (WebCore::MediaControlRootElementChromium::changedMute):
> +        (WebCore::MediaControlRootElementChromium::changedVolume):
> +        (WebCore::MediaControlRootElementChromium::enteredFullscreen):
> +        (WebCore::MediaControlRootElementChromium::exitedFullscreen):
> +        (WebCore::MediaControlRootElementChromium::showVolumeSlider):
> +        (WebCore::MediaControlRootElementChromium::shadowPseudoId):
> +        * html/shadow/MediaControlRootElementChromium.h: Added.

If these files were just cloned from existing files you should say so, and there is no need to list all of the "changed" functions here. If they aren't exact clones, please say what changed in each function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.