[Webkit-unassigned] [Bug 59017] [GTK] Implement History API FrameLoaderClient methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59017


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-04-20 13:09:29 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=90386&action=review

Seems okay, but please consider my comments below when landing.

> Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:913
> +    WebKitWebView* webView = getViewFromFrame(m_frame);
> +    WebKitWebFrame *mainFrame = webView->priv->mainFrame;
> +    WebKitWebDataSource *dataSource = webkit_web_frame_get_data_source(mainFrame);
> +    bool loaderCompleted = !webkit_web_data_source_is_loading(dataSource);
> +
> +    if (!loaderCompleted)
> +        return;

This can all be reduced to two lines with something like:

if (core(getViewFromFrame(m_frame))->mainFrame()->loader()->activeDocumentLoader()->isLoadingInAPISense())
    return;

I would also leave a comment explaining why you don't want to send these signals during loading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.