[Webkit-unassigned] [Bug 58671] LEFilter change doesn't compile on ARM neon targets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58671


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krit at webkit.org




--- Comment #10 from Dirk Schulze <krit at webkit.org>  2011-04-20 12:53:15 PST ---
(In reply to comment #7)
> Created an attachment (id=90387)
 --> (https://bugs.webkit.org/attachment.cgi?id=90387&action=review) [details]
> Patch to WebCore/WebCore.gyp/WebCore.gyp
> 
> We need this additonal patch to fix the includes.

The fix looks good. Just some notes. You must upload your fix as patch, not as application/octet-stream. Every fix needs a ChangeLog entry. Please create this with:

Tools/Scripts/prepareChangelog --bug58671 --email=<your email>

and add a comment to the ChangeLog. Something like "Build fix for Chromium on Neon platform. Added filter/arm directory to build system."

Upload the patch with:

Tools/Scripts/webkit-patch upload

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.