[Webkit-unassigned] [Bug 56682] Opening link with unspecific hash in a new tab (except context menu) twice in a row results in hash for current window changing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56682





--- Comment #6 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2011-04-20 11:11:02 PST ---
(From update of attachment 87157)
View in context: https://bugs.webkit.org/attachment.cgi?id=87157&action=review

Thanks for review! :)
I've prepared a test case for this.

>> Source/WebCore/loader/PolicyChecker.cpp:69
>> +        const UIEventWithKeyState* keyStateEvent = findEventWithKeyState(const_cast<Event*>(action.event()));
> 
> const_cast ?  That doesn't seem right.

Done.

>> Source/WebCore/loader/PolicyChecker.cpp:74
>> +        }
> 
> PolicyChecker shouldn't know anything about ctrlKey or metaKey.  I think this patch is improperly factored.

Well, if PolicyChecker shouldn't, I think FrameLoader can check this.
Anyway, somewhere should check this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.