[Webkit-unassigned] [Bug 58886] Web Inspector: Render non-document HTML resources as HTML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58886


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90351|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2011-04-20 10:16:06 PST ---
(From update of attachment 90351)
View in context: https://bugs.webkit.org/attachment.cgi?id=90351&action=review

> Source/WebCore/inspector/front-end/NetworkItemView.js:48
> +        var responseView = new WebInspector.ResourceSourceFrame(resource);

You could reuse existing SourceFrame in case previewView is instance of ResourceSourceFrame. In fact, you should adjust resourceViewForResource to cache only SourceFrame views.

> Source/WebCore/inspector/front-end/Resource.js:795
> +            if (data == null)

pending callbacks should be notified upon missing content.

> Source/WebCore/inspector/front-end/ResourceHTMLView.js:52
> +        this.element.textContent = "";

this.element.removeChildren()

> Source/WebCore/inspector/front-end/ResourceView.js:49
> +        return new WebInspector.ResourceHTMLView(resource);

Reuse SourceFrame-based views when possible as per comment above.

> Source/WebCore/inspector/front-end/ResourceView.js:80
> +        if (WebInspector.ResourceJSONView.parseJSON(resource.content))

This seems to be a bit too expensive. Testing for the prototype would be sufficient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.