[Webkit-unassigned] [Bug 58960] [Chromium]Mac UI polish to add left/right padding space for autofill popup window.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58960


David Holloway <dhollowa at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dhollowa at chromium.org




--- Comment #7 from David Holloway <dhollowa at chromium.org>  2011-04-20 09:01:34 PST ---
The corresponding Chromium bug is: http://crbug.com/51077

This is a follow-up to WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=58505

(In reply to comment #6)
> (From update of attachment 90299 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review
> 
> Seems OK to me besides the nits below.
> 
> > Source/WebCore/ChangeLog:9
> > +        No new test because Chromium Autofill popup window doesn't have any test framework.
> 
> Thank you for explaining.
> 
> > Source/WebCore/ChangeLog:12
> > +        The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
> 
> Can you provide more context? like a bug link?
> 
> > Source/WebCore/rendering/RenderThemeChromiumMac.h:59
> > +    int popupInternalPaddingLeft(RenderStyle*) const;
> > +    int popupInternalPaddingRight(RenderStyle*) const;
> 
> Aren't these virtual calls? (we always mark virtual calls as virtual even though it's not strictly required by the spec).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.