[Webkit-unassigned] [Bug 58953] [V8] Use implicit references for V8 listeners on DOM nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58953





--- Comment #3 from Adam Barth <abarth at webkit.org>  2011-04-19 18:40:10 PST ---
(From update of attachment 90287)
View in context: https://bugs.webkit.org/attachment.cgi?id=90287&action=review

The V8-specific could should be in bindings/v8.  You might need to build some sort of abstraction to make that work, but your patch has it's dependencies backwards.

> Source/WebCore/bindings/v8/V8AbstractEventListener.h:96
> +        v8::Persistent<v8::Object> getExistingListenerObjectPeristentHandle()

getExistingListenerObjectPeristentHandle => listener ?

We don't usually start functions with the word "get".  Also, we can tell it returns a persistent handle by the return type.

> Source/WebCore/dom/EventListener.h:61
> +#if USE(V8)
> +        virtual bool isV8EventListener() const { return false; }
> +#endif

Frown.

> Source/WebCore/dom/EventTarget.cpp:39
> +#if USE(V8)
> +#include "V8AbstractEventListener.h"
> +#endif

This is a backwards dependency.

> Source/WebCore/dom/EventTarget.cpp:381
> +#if USE(V8)

This code shouldn't be here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.