[Webkit-unassigned] [Bug 58944] New: bidiNext should be split into two separate functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58944

           Summary: bidiNext should be split into two separate functions
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: hyatt at apple.com, mitz at webkit.org, rniwa at webkit.org,
                    leviw at chromium.org


bidiNext should be split into two separate functions

bidiNext has two (mostly unrelated) modes.

Either it's walking to the next RenderText, or it's walking to the next RenderInline.  This is controlled (confusingly) by the skipInlines bool, which when false, puts it in "walk to inlines" mode.

Here are the 7 callsites:

InlineIterator.h:             o = bidiNext(root, o, resolver, skipInlines); // Just plumbing
InlineIterator.h:         o = bidiNext(root, o, resolver, skipInlines); // Just plumbing

InlineIterator.h:     moveTo(bidiNext(m_root, m_obj, resolver), 0); // The normal walk-to-the-next  RenderText mode (and the only place that ever notifies the resolver when entering/leaving inlines).

InlineIterator.h:             obj = bidiNext(m_sor.root(), obj); // Used by InlineBidiIterator, really should just be an InlineIterator.increment() call.

RenderBlock.cpp:             o = bidiNext(this, o, 0, false, &endOfInline); // Wants all inlines
RenderBlockLineLayout.cpp:             o = bidiNext(this, o, 0, false, &endOfInline); // Wants all inlines

RenderBlockLineLayout.cpp:     RenderObject* next = bidiNext(block, o); // Looking for the next RenderText, probably should be an InlineIterator.increment() call.
RenderBlockLineLayout.cpp:         RenderObject* next = bidiNext(this, o); // Also probably should just be an InlineIterator.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.