[Webkit-unassigned] [Bug 47210] CSS 2.1 failure: bidi-* tests fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47210





--- Comment #10 from Levi Weintraub <leviw at chromium.org>  2011-04-19 10:57:28 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=89650&action=review

> Source/WebCore/platform/text/BidiResolver.h:478
> +void BidiResolver<Iterator, Run>::createBidiRunsForLine(const Iterator& end, VisualDirectionOverride override, bool hardLineBreak, bool inQuirksMode)

Since this takes inQuirksMode as a parameter, we don't need to track quirksMode in the BidiContext at all; QuirksMode applies to the document as a whole, and BidiContext is a stack of contexts all within that Document's scope. This entire patch could be simplified to just this function's change of signature and an if that avoids copying the contexts for strict mode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.