[Webkit-unassigned] [Bug 58784] [Chromium] Enable QUOTA API at runtime if enable-quota flag is given

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58784





--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org>  2011-04-19 06:41:59 PST ---
(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 90031 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review
> > 
> > Please wait for Darin's ok since you did a chromium public api change.
> 
> I didn't see Darin's ok in here.

Oops, sorry I overlooked the commend... ok I will revert the change.

> > > Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:323
> > > +void WebRuntimeFeatures::enableQuota(bool enable)
> > 
> > I suspect you'll trigger a warning and thus a compile error due to unused enable when QUOTA isn't enabled.
> 
> It doesn't look like this was handled.

Sorry I didn't reply.  I thought it would be ok (and seems to be ok) as the file have a lot of similar lines (i.e.g void WebRuntimeFeatures::enableXxx(bool enable) with #if ENABLE(XXX) in body).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.