[Webkit-unassigned] [Bug 52788] Any class other than Element should not use setShadowHost()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52788


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89980|review?                     |review-
               Flag|                            |




--- Comment #7 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-04-18 15:27:00 PST ---
(From update of attachment 89980)
View in context: https://bugs.webkit.org/attachment.cgi?id=89980&action=review

Looks great, just a few nits.

> Source/WebCore/dom/EventDispatcher.cpp:136
> +            if ((*i)->isShadowRoot() || (*i)->isSVGShadowRoot()) {

This (and hereon) should be an inline helper function.

> Source/WebCore/dom/EventDispatcher.cpp:246
> +            ancestor = ancestor->isShadowRoot() ? ancestor->shadowHost() : ancestor->svgShadowHost();

You are querying isShadowRoot twice here. Perhaps optimize the loop a bit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.