[Webkit-unassigned] [Bug 58747] [Windows Debug Tests] 20+ tests crash in localizedString since r84094

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58747


Jessie Berlin <jberlin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jberlin at webkit.org




--- Comment #2 from Jessie Berlin <jberlin at webkit.org>  2011-04-18 06:55:39 PST ---
(In reply to comment #1)
> Here's the assertion:
> 
> http://trac.webkit.org/browser/trunk/Source/WebCore/platform/win/LocalizedStringsWin.cpp?rev=84087#L82
> 
>     ASSERT_WITH_MESSAGE(result.get() != notFound, "could not find localizable string %s in bundle", key);

The assertion failure seems to be happening under places like WebCore::imageTitle. Wouldn't it be expected to not find all image titles localized in the webkit bundle?

Maybe that assertion needs to removed and replaced with:

if (result.get() != notFound)
    return result.get();

and otherwise let it fall through to the non-cf version? (which just returns the string itself?)

Or maybe we shouldn't be trying to localize image titles at all?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.