[Webkit-unassigned] [Bug 58537] Web Inspector: TAB should not move focus from the text editor while live editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 18 02:58:12 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58537


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89791|review?                     |review+
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2011-04-18 02:58:11 PST ---
(From update of attachment 89791)
View in context: https://bugs.webkit.org/attachment.cgi?id=89791&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:243
> +        var handleUndo = this._mainPanel.handleUndoRedo.bind(this._mainPanel, 0);

Why do we prefer 0/1 to false/true here?

> Source/WebCore/inspector/front-end/TextViewer.js:951
> +        this._setCaretLocation(newRange.endLine, newRange.endColumn);

Shouldn't we scroll the viewer to the new caret location?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list