[Webkit-unassigned] [Bug 38554] [Qt] The image plugin used for decoding images should be configurable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38554





--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2011-04-17 22:21:38 PST ---
(From update of attachment 89629)
View in context: https://bugs.webkit.org/attachment.cgi?id=89629&action=review

> Source/WebCore/page/Settings.cpp:57
> +    for (Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext())
> +        frame->document()->cachedResourceLoader()->setLoadJPEGImage(page->settings()->loadsSiteJPEGImagesIgnoringImageLoadingSetting());

this could be called outside the loop.

page->settings()->loadsSiteJPEGImagesIgnoringImageLoadingSetting()

> Source/WebCore/page/Settings.cpp:63
> +    for (Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext())
> +        frame->document()->cachedResourceLoader()->setLoadPNGImage(page->settings()->loadsSitePNGImagesIgnoringImageLoadingSetting());

Ditto

> Source/WebKit/qt/Api/qwebsettings.cpp:630
> +void QWebSettings::enableLoadingImage(const QString &image)

& positioned wrong.

The goal should be clean, and comments are needed.

> Source/WebKit/qt/Api/qwebsettings.cpp:638
> +    if (image == QLatin1String("jpeg"))
> +        d->settings->setLoadsSiteJPEGImagesIgnoringImageLoadingSetting(true);
> +    else if(image == QLatin1String("png"))
> +        d->settings->setLoadsSitePNGImagesIgnoringImageLoadingSetting(true);

Only caring about these two formats?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.