[Webkit-unassigned] [Bug 58746] Move WebNodeHighlighter into its own file
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 17 13:11:21 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=58746
Joseph Pecoraro <joepeck at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89958| |review?, commit-queue?
Flag| |
--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org> 2011-04-17 13:11:21 PST ---
Created an attachment (id=89958)
--> (https://bugs.webkit.org/attachment.cgi?id=89958&action=review)
[PATCH] Extract into its own file
Some minor cleanup in the process:
- fix WebInspectorClient constructor
- remove "WebNodeHightlighter delegate" methods on WebInspectorWindowController
which were never called because it was never set to be the delegate.
- added [super init] boilerplate to WebNodeHighligher's constructor
Also, the ObjC classes in WebInspectorClient don't properly initialize self.
They just call the super methods but don't assign to self. Should I fix those
up as well?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list