[Webkit-unassigned] [Bug 58719] Cancelling fullscreen doesn't properly reset internal state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58719





--- Comment #3 from Andrew Scherkus <scherkus at chromium.org>  2011-04-17 11:31:18 PST ---
Sorry for combining clean-up with a bug fix :(

In essence the fix is a one-liner: the addition of "m_fullScreenElement = 0" to webkitDidExitFullScreen

Technically m_isFullScreen should have guarded against being able to re-cancel full screen (see Document::webkitCancelFullScreen), but because we only check m_fullScreenElement, we execute the cancel code again and Bad Things happen.

Instead of having both m_isFullScreen and m_fullScreenElement track whether Document is in full screen, it seems safer to rely on whether m_fullScreenElement set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.